Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement rotation functionality on mouse/cursor based platforms #1568

Closed
BearnLee opened this issue Jun 27, 2023 · 6 comments · Fixed by #1592 or #1642
Closed

[FEATURE] Implement rotation functionality on mouse/cursor based platforms #1568

BearnLee opened this issue Jun 27, 2023 · 6 comments · Fixed by #1592 or #1642
Labels
feature This issue requests a new feature P: 2 (soon™?)

Comments

@BearnLee
Copy link

What do you want implemented?

Have you considered the function of rotating the map by right-clicking and long-pressing the map?

What other alternatives are available?

Have you considered the function of rotating the map by right-clicking and long-pressing the map?

Can you provide any other information?

Have you considered the function of rotating the map by right-clicking and long-pressing the map?

Severity

Annoying: Currently have to use workarounds

@BearnLee BearnLee added the feature This issue requests a new feature label Jun 27, 2023
@JaffaKetchup JaffaKetchup changed the title [FEATURE] Have you considered the function of rotating the map by right-clicking and long-pressing the map? [FEATURE] Implement rotation functionality on mouse/cursor based platforms Jun 27, 2023
@JaffaKetchup
Copy link
Member

Hi @BearnLee,
Thanks for reminding us! We're not sure whether right click is the best way to handle this, as it may cause issues on the web, but we might be able to handle keyboard modifiers.

@BearnLee
Copy link
Author

Ok,thx!

@JaffaKetchup JaffaKetchup moved this from To do to In progress in v6 Release Planning Jul 13, 2023
@JaffaKetchup
Copy link
Member

A few attempts have been made to implement this.

@TesteurManiak managed to piece together a POC that works with the CTRL key and uses a simple maths function to rotate the maths. The result, whilst working, was not 100% satisfactory for a few reasons.

We've also tried porting OpenLayers' code from this source file which does a similar thing. The web demo for that works really nicely: https://openlayers.org/en/latest/examples/rotation.html. However, our implementation attempts did not reproduce this behaviour.

We're not sure whether this will make it into v6. We want it to, so we'll probably have another attempt, but any help from any readers of this would be greatly appriciated!

@ibrierley
Copy link
Collaborator

Where's the POC or the port ?

@JaffaKetchup
Copy link
Member

@ibrierley Check the private Discord channel for those snippets and a link above that for a 'full' test implementation.

@ibrierley
Copy link
Collaborator

ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue requests a new feature P: 2 (soon™?)
Projects
No open projects
3 participants