Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ksoup with dependencies on okio & ktor #30

Closed
vanniktech opened this issue May 13, 2024 · 2 comments
Closed

ksoup with dependencies on okio & ktor #30

vanniktech opened this issue May 13, 2024 · 2 comments
Assignees

Comments

@vanniktech
Copy link

I am currently using com.fleeksoft.ksoup:ksoup:0.1.2 however it is pulling both okio, ktor, kotlinx-datetime as dependencies. Why is this required? Looking at the current state of the repo, I'd assume I only get them when I'm pulling ksoup-network. Has this been changed and isn't reflected in the 0.1.2 version? If not, why are the three dependencies required for the core ksoup bits?

@itboy87
Copy link
Collaborator

itboy87 commented May 14, 2024

Hi @vanniktech , okio is required for I/O operations. kotlinx-datetime is utilized for ConstrainableSource to constrain the buffer with time, and ktor-core is being added for charset encoding and resolving URLs using io.ktor.http.Url.

@vanniktech
Copy link
Author

I understand, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants