Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SOFA json feed for validating Apple-specific CVE data #18747

Open
nonpunctual opened this issue May 3, 2024 · 15 comments
Open

Add SOFA json feed for validating Apple-specific CVE data #18747

nonpunctual opened this issue May 3, 2024 · 15 comments
Labels
~csa Issue was created by or deemed important by the Customer Solutions Architect. customer-pingali customer-reedtimmer ~sc Request is a requirement in a presales opportunity

Comments

@nonpunctual
Copy link
Contributor

nonpunctual commented May 3, 2024

The Mac Admins foundation has created a data feed for Apple OS security information:

https://sofa.macadmins.io/
https://sofa.macadmins.io/v1/macos_data_feed.json

Not a primary source of CVE data but maybe important as a way of validating sources for Apple-specific issues / products, i.e., this feed will contain the CVE data for Apple software that has been researched by Apple.

Problem

Improve Fleet's vunerability data with as many high-quality data sources as possible.

Potential solutions

  1. Integrate the SOFA feed into Fleet's vulnerability data stack.

heads-up @mostlikelee @sharon-fdm

@nonpunctual nonpunctual added :product Product Design department (shows up on 🦢 Drafting board) ~feature fest Will be reviewed at next Feature Fest ~csa Issue was created by or deemed important by the Customer Solutions Architect. labels May 3, 2024
@nonpunctual
Copy link
Contributor Author

nonpunctual commented May 3, 2024

@noahtalerman @marko-lisica An osquery extension has already been built for this. Can we include the entire macadmins osquery_extension in our repo? https://grahamgilbert.com/blog/2024/05/03/investigating-unpatched-cves-with-osquery-and-sofa/ https://github.com/macadmins/osquery-extension

@nonpunctual
Copy link
Contributor Author

Screenshot 2024-05-06 at 9 46 05 AM

@noahtalerman
Copy link
Member

Hey @nonpunctual do you know what we'd get from the SOFA feed that we don't already have in Fleet? (from NVD)

What data are we missing? What workflows are we missing?

Maybe we can ask the customer too.

Can we include the entire macadmins osquery_extension in our repo?

We can certainly add the tables from this extension to fleetd.

@noahtalerman noahtalerman removed the :product Product Design department (shows up on 🦢 Drafting board) label May 7, 2024
@nonpunctual
Copy link
Contributor Author

nonpunctual commented May 7, 2024

@noahtalerman

https://sofa.macadmins.io/
https://sofa.macadmins.io/v1/macos_data_feed.json

this feed is new. I don't believe it's possible that we are currently getting this data in exactly this way. We should be taking in as much CVE data as we can get & also cross-validating sources to prevent false positives. this data can act as a primary source or as a cross-reference to validate the CVEs that Apple has researched & published.

@getvictor
Copy link
Member

We will add the sofa_security_release_info and sofa_unpatched_cves tables. Sample result from sofa_security_release_info

image

@noahtalerman
Copy link
Member

We will add the sofa_security_release_info and sofa_unpatched_cves tables.

@getvictor are these tables being added as part of this bug? (targeted for 4.50) #18808

@noahtalerman
Copy link
Member

Integrate the SOFA feed into Fleet's vulnerability data stack.

@nonpunctual before we can prioritize this solution I think we have to do some research to see if there is a problem w/ Fleet's vulnerability data.

Using SOFA as a reference, are there false positives / negatives in Fleet?

Do you think the customer success team can take on this research?

@getvictor
Copy link
Member

We will add the sofa_security_release_info and sofa_unpatched_cves tables.

@getvictor are these tables being added as part of this bug? (targeted for 4.50) #18808

@noahtalerman Yes

@nonpunctual
Copy link
Contributor Author

nonpunctual commented May 8, 2024

@noahtalerman I am happy to research any questions you have. What exactly needs to be researched?

The goal is to simply add the extensions so this data is available as a fleetd osquery table which Victor has already said he could do. This should be pretty low LoE.

Regardless if this data is redundant or not I believe we should be including these extensions. The fact that it's been adopted in the Mac Admins osquery extensions should be our guide to understanding the importance of being able to query this data for endpoint-ops & MDM customers.

@noahtalerman
Copy link
Member

What exactly needs to be researched?

@nonpunctual here's what I'm thinking:

Using SOFA as a reference, are there false positives / negatives in Fleet?

(removing this from feature fest because the table is being added as part of a separate issue)

@noahtalerman noahtalerman removed the ~feature fest Will be reviewed at next Feature Fest label May 9, 2024
@fleet-release
Copy link
Contributor

SOFA feed in Fleet,
Apple's secrets now discrete,
Security complete.

@nonpunctual
Copy link
Contributor Author

@noahtalerman Example of Fleet vulnerability data not matching Apple:

Screenshot 2024-05-10 at 8 41 49 AM

@nonpunctual nonpunctual reopened this May 10, 2024
@nonpunctual
Copy link
Contributor Author

The model data is extremely valuable as well. Reopening to request that we consume the entire data feed if we are only planning on getting the CVE data. Thanks.

@noahtalerman
Copy link
Member

Example of Fleet vulnerability data not matching Apple:

Hey @nonpunctual can you please open a bug report for this? We want to treat all false positives as bugs.

@nonpunctual
Copy link
Contributor Author

@sharon-fdm Noah asked me to create separate issues for each false positive CVE so they could be tracked as separate bugs. Happy to have them all related to a single issue. Thanks!

@dherder dherder added the ~sc Request is a requirement in a presales opportunity label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~csa Issue was created by or deemed important by the Customer Solutions Architect. customer-pingali customer-reedtimmer ~sc Request is a requirement in a presales opportunity
Projects
None yet
Development

No branches or pull requests

5 participants