Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for QuerySidePanel Component #8831

Closed
ghernandez345 opened this issue Nov 28, 2022 · 5 comments
Closed

Add Tests for QuerySidePanel Component #8831

ghernandez345 opened this issue Nov 28, 2022 · 5 comments
Assignees
Labels
~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.)
Milestone

Comments

@ghernandez345
Copy link
Contributor

ghernandez345 commented Nov 28, 2022

Adding tests for the QuerySidePanel component

Now subtask of #11832

@ghernandez345 ghernandez345 added the ~frontend Frontend-related issue. label Nov 28, 2022
@RachelElysia RachelElysia self-assigned this May 30, 2023
@RachelElysia RachelElysia added :product Product Design department (shows up on 🦢 Drafting board) #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. and removed :product Product Design department (shows up on 🦢 Drafting board) labels May 30, 2023
@lukeheath lukeheath added the ~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. label May 30, 2023
@lukeheath
Copy link
Member

@sharon-fdm This also needs an estimate.

@sharon-fdm
Copy link
Contributor

This is actually a sub task of #11832.
@RachelElysia let's connect them.

@lukeheath lukeheath added story A user story defining an entire feature ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.) and removed story A user story defining an entire feature labels May 30, 2023
@RachelElysia
Copy link
Member

remarkjs/react-markdown#635 (comment)

// jest.config.js
// move "jest" config from package.json to jest.config.js
const esModules = [ // Copy from here 👈
"react-markdown",
"vfile",
"unist-.+",
"unified",
"bail",
"is-plain-obj",
"trough",
"remark-.+",
"mdast-util-.+",
"micromark",
"parse-entities",
"character-entities",
"property-information",
"comma-separated-tokens",
"hast-util-whitespace",
"remark-.+",
"space-separated-tokens",
"decode-named-character-reference",
"ccount",
"escape-string-regexp",
"markdown-table",
"trim-lines",
].join("|"); // To here 👈

module.exports = {
...
transform: {
'^.+\.(js|jsx|mjs|cjs|ts|tsx)$': '/config/jest/babelTransform.js',
[(${esModules}).+\\.js$]: '/config/jest/babelTransform.js', // Add this line 👈
'^.+\.css$': '/config/jest/cssTransform.js',
'^(?!.*\.(js|jsx|mjs|cjs|ts|tsx|css|json)$)':
'/config/jest/fileTransform.js',
},
transformIgnorePatterns: [
// Update from this 👈
// "[/\\]node_modules[/\\].+\.(js|jsx|mjs|cjs|ts|tsx)$",
[/\\\\]node_modules[/\\\\](?!${esModules}).+\\.(js|jsx|mjs|cjs|ts|tsx)$, // To this 👈
'^.+\.module\.(css|sass|scss)$',
],
...
};

@RachelElysia
Copy link
Member

jestjs/jest#11067 (comment)

When babel is in .babel.rc there's an issue, so you have to change it to babel.config.json

@fleet-release
Copy link
Contributor

QuerySidePanel tests,
Cloud city code now secured,
Platform blossoms strong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.)
Development

No branches or pull requests

5 participants