Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to deselect via lasso? #105

Open
japrescott opened this issue Feb 20, 2023 · 1 comment
Open

allow to deselect via lasso? #105

japrescott opened this issue Feb 20, 2023 · 1 comment
Labels
improvement Feature improvement or enhancement

Comments

@japrescott
Copy link
Contributor

Hey @flekschas

Thanks again for this great library. As an idea I was wondering how easy it would be to after selecting different regions with the lasso tool, to then be able to deselect certain subregions also with the lasso mode, eg. when pressing shift+option+ctrl?
I am happy to have a poke at this if you think this would be a good addition?

Best

@flekschas
Copy link
Owner

I think this would be a nice addition. And it shouldn't be too hard to implement this but it'd required adjusting a few different functions:

  1. We need to extend checkModKey() to accept a tuple of action keys
  2. We need to extend the handling of the action key map to allow combinations of multiple keys. Maybe via concatenation with +. E.g., alt+shift.
  3. We need to add a new action key for removing points. E.g., KEY_ACTION_REMOVE
  4. We need to extend the select(), lassoEnd() lasso manager's end() functions to allow remove.

@flekschas flekschas added the improvement Feature improvement or enhancement label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature improvement or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants