-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inability to draw with active filter #136
Comments
Could you provide a small example illustrating the problem? I'm not 100% sure I fully understand what you mean with
Is the following the issue:
If I understand correctly, one solution might be to add an option to The first option (maybe we call it
I don't see the use case for this. What's the point in changing the data and not re-drawing the scatterplot? E.g., if the One thing I can see is that if only the |
@flekschas Here is a reproducible demo of the problem: https://codesandbox.io/s/awesome-hertz-gpjyw8 (Uncomment By the way, I was not aware that you can assign new values to the current object (by reference). Maybe for the meantime I can use this and try to make a PR about |
Abstract (Enhancement)
Currently, it is not possible to draw points with active filter. This results in enforcing users to first draw the points and then filter, which itself results in a flashy UI.
What triggered the issue
Users may want to change the point values for the
colorBy
. For example, you want to color by for differentValue A
. In order to do this with the current API, the only way is to redraw by passing a new points object. (E.G[[x,y,A,B]...
).However, while doing this, you may have active filter applied. The filter is reset on the
.draw
call.Proposal
To improve the user experience, it would be useful to be able to set
filteredPoints
while drawing already, or give the ability for users to pass new data objects for the points without needing to redraw (I guess this may be more complex)regl-scatterplot
.The text was updated successfully, but these errors were encountered: