-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building Issue and Suggestion. #3
Comments
That's strange, and indeed replay doesn't have a Path field, so I don't know how would have compiled before. Edit: Obviously was because I didn't push the local changes from osu-tools... I did limit to 6 months because it takes a bit to load when it has to load many replays (because it needs accessing to .osu files to get the PP). I will add an option for displaying all replays but still, I will need to load the PP lazily so it doesn't block the GUI. |
I think it should build now, also added the option for loading replays from all time. Fool of me for not having a CI setup... |
Thanks for the quick response. Last thing I got was
I fixed this by copying bnch\osubinary into the github.com\flesnuk folder and got it compiling. |
Problems building your source.
src\github.com\flesnuk\biku\osuhm\replaynotifier.go:48:9: replay.Path undefined (type osu.Replay has no field or method Path)
Also a suggestion, I was doing this so I could load replays past 6 months. If you could make it so we could load replays from back past 6 months that would be nice. I would like to see every single replay I ever did.
EDIT: I added a temporary patch onto the osu forums. I will fork when I can and make some modifications. I think I can improve loading performance. https://osu.ppy.sh/forum/p/6501398
The text was updated successfully, but these errors were encountered: