Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Unify all open_...() method into open() #3367

Closed
bleudev opened this issue May 27, 2024 · 2 comments
Closed

Feature request: Unify all open_...() method into open() #3367

bleudev opened this issue May 27, 2024 · 2 comments

Comments

@bleudev
Copy link
Contributor

bleudev commented May 27, 2024

Please Describe The Problem To Be Solved

Feodor said in review of my pull (#3172) that it'll be great if will there is open() method. I'm requesting to add this in my future pull and requesting realisation. f. e.

page.open('drawer')
# or
drawer = ...
page.open('drawer', drawer)

Also it'll great that will there is close() method

page.close('drawer')
@ndonkoHenri
Copy link
Collaborator

if drawer isn't in page it will be appended to this page

What do you mean?

@bleudev
Copy link
Contributor Author

bleudev commented May 27, 2024

if drawer isn't in page it will be appended to this page

What do you mean?

if drawer isn't in page -> page.drawer = drawer

Actually when it's in page ->
page.drawer = drawer

Then we can just add page.drawer = drawer in all ways.

@bleudev bleudev changed the title Unify all open_...() method into open() Feature request: Unify all open_...() method into open() Jun 1, 2024
@bleudev bleudev closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants