Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further restrict time monitor #1521

Closed
momchil-flex opened this issue Mar 6, 2024 · 4 comments
Closed

Further restrict time monitor #1521

momchil-flex opened this issue Mar 6, 2024 · 4 comments
Assignees
Labels
2.7 will go into version 2.7.*

Comments

@momchil-flex
Copy link
Collaborator

Some further restrictions or change of default settings for time monitors can be beneficial to avoid generating unintendedly large amount of data. Options to consider:

  • Set recording interval > 1 by default.
  • Warn or error if larger than some number of time steps present.
  • Only apply the above for monitors larger than 0D.

@xin-flex any comments?

@momchil-flex momchil-flex self-assigned this Mar 6, 2024
@momchil-flex momchil-flex added the 2.7 will go into version 2.7.* label Mar 6, 2024
@momchil-flex
Copy link
Collaborator Author

Actually note that we already have this warning:

15:49:45 PST WARNING: The monitor 'interval' field was left as its default      
             value, which will set it to 1 internally. A value of 1 means that  
             the data will be sampled at every time step, which may potentially 
             produce more data than desired, depending on the use case. To      
             reduce data storage, one may downsample the data by setting        
             'interval > 1' or by choosing alternative 'start' and 'stop' values
             for the time sampling. If you intended to use the highest          
             resolution time sampling, you may suppress this warning by         
             explicitly setting 'interval=1' in the monitor. 

@xin-flex
Copy link
Contributor

xin-flex commented Mar 7, 2024

Thanks, Momchil! For 0D, let's have an error if larger than certain time steps.

@momchil-flex
Copy link
Collaborator Author

You mean for > 0D?

@xin-flex
Copy link
Contributor

xin-flex commented Mar 7, 2024

You mean for > 0D?

Yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7 will go into version 2.7.*
Projects
None yet
Development

No branches or pull requests

2 participants