Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add title and sr only text to links #29

Merged

Conversation

BBlackwo
Copy link
Contributor

@BBlackwo BBlackwo commented Jun 15, 2022

A few accessibility improvements recommended by font-awesome.

Adds to links:

  • Title on hover
  • Screen reader only text

Screenshot from 2022-06-16 08-21-30

If you're happy to accept more PRs, I've got some other changes I'd like to suggest that I've made to my dev landing page.

Thanks for the great template! :)

@BBlackwo
Copy link
Contributor Author

@flexdinesh are you able to have a look at this PR? Or are you not accepting PRs at the moment?

@flexdinesh
Copy link
Owner

This is great! Thanks for the PR mate. Happy to accept more PRs. 🙌

@flexdinesh flexdinesh merged commit d96e4d8 into flexdinesh:master Aug 25, 2022
@BBlackwo BBlackwo deleted the feature/sr-only-text-and-title branch August 26, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants