Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Jupyter server still doesn't work over HTTPS #316

Closed
alexveden opened this issue Dec 11, 2016 · 3 comments
Closed

Remote Jupyter server still doesn't work over HTTPS #316

alexveden opened this issue Dec 11, 2016 · 3 comments

Comments

@alexveden
Copy link
Contributor

alexveden commented Dec 11, 2016

After PR #307 been merged I still have problems with remote notebook connections.

I've fixed this but I'm not able to create new pull request, can you help me with that?

@almarklein
Copy link
Member

Sure! How familiar are you with git?

I tried to outline the general approach below, let me know if things are unclear of if you get stuck. A summary like this should probably be put on the wiki:

To get familiar with git, these are great starting points:

Setting things up:

  • Create a fork of the repo that you want to contribute to, by clicking on the "fork" button on github. This will add a repo with the same name in your personal github account.
  • Make a clone of your fork on your local machine. In your fork, press the "clone or download" to get the command. My guess it will be git clone https://github.com/alexveden/flexx.git.
  • Run git remote add upstream https://github.com/zoofIO/flexx.git so that you can easily update to the latest version.
  • Add the directory that was just created to your PYTHONPATH, or use pip install -e . for an editable install; you can now make changes to the source and try them without needing a reinstall.

Making a change and pull request:

  • First update to latest version: git checkout master followed by git pull upstream master.
  • Create a new branch git checkout -b my-branch-name
  • Make your changes
  • After a piece of work is done, commit it: git commit -am 'summary of made changes'
  • Optionally, make more changes, and commit them ...
  • Push your commits to your fork git push origin my-branch-name
  • In the github pages of your fork and the official Flexx repo you'll see a "create pull request" button.

Review process:

  • Someone will probably request more changes.
  • You commit and push changes as above, and they shall appear in the PR.
  • Possibly, this is repeated ...
  • When your PR is merged, update again: git checkout master followed by git pull upstream master.
  • You can now delete your branch using git branch -D my-branch-nam.

@almarklein
Copy link
Member

BW: if it's a small change confined to a single file, you can edit the file directly on Github and create a PR from there.

@almarklein
Copy link
Member

Closed by #317

@almarklein almarklein modified the milestones: v0.5, v0.4.2 Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants