Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: isHydrated() remains true even after reset() #10

Closed
starfishpatkhoo opened this issue May 6, 2024 · 5 comments
Closed

Bug: isHydrated() remains true even after reset() #10

starfishpatkhoo opened this issue May 6, 2024 · 5 comments

Comments

@starfishpatkhoo
Copy link

I think isHydrated() should be cleared when we reset()

$user->find();
echo $user->isHydrated() ? "Yes" : "No";  // Yes
echo $user->name;  // "John Doe"
$user->reset();
echo $user->isHydrated() ? "Yes" : "No";  // Yes
var_dump($user->name);  // NULL
var_dump($user->toArray());  // array(0){}
@n0nag0n
Copy link
Contributor

n0nag0n commented May 6, 2024

That prob needs to be tweaked as well! If you want an easy PR opportunity, this is your moment ;) haha

@starfishpatkhoo
Copy link
Author

That prob needs to be tweaked as well! If you want an easy PR opportunity, this is your moment ;) haha

Ha ha ha ! Let me hit my deadline first.. Then I can come back and look at this.. ^_^

@n0nag0n
Copy link
Contributor

n0nag0n commented May 7, 2024

e90cf11 No worries, I gotcha covered. I'll release this soon, but you can use the dev-master if you need to

@n0nag0n n0nag0n closed this as completed May 7, 2024
@starfishpatkhoo
Copy link
Author

Thanks man.. will check it out.. I need to hit my project deadline first..

@n0nag0n
Copy link
Contributor

n0nag0n commented May 8, 2024

Good luck meeting your deadlines!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants