-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to Exclude path to avoid picking up localisation from Pods and imported libs #63
Comments
What about we simply add |
Yes, of course Still, there may be cases when you integrate some library by copying sources or using git submodule and it appears in project root among your regular sources. |
Sure, there could be such cases. If you want, you can add options named Unfortunately I don't have much free time right now to fix issues that are no real problems. You had a real problem with the Pods folder which many others might have, too. So I suggested a solution for that. For any other ideas I'm thankful for your issue but I won't have time to deal with it anytime soon. I'd happily merge it though if it was implemented, tested and documented in a PR though. ;) |
No problem. Should I add |
A PR would be nice! 🙂 |
The fix from dd5d07e doesn't address the OP's request to avoid pulling in 3rd party (cocoapod) strings. The array to which I've implemented a similar directory filter in |
Please open a new issue and feel free to post your change as a PR, independent from which issue it fixes. Would be great 👍 |
The discussion appears to continue at #156 |
Would be great to have --exclude path option, to avoid picking up localisation from Pods and imported libraries
For example project has this structure:
running
bartycrouch code -p .
will include localization from Pods or any third party libraries happen to be relative to project root. It mixes those 3rd party strings into your Localizable.strings.Yes, the sources can be organized under something like /src in root of project, but that never happens. Sources are never in their own separate subtree.
As workaround paths can be included by running command multiple times.
bartycrouch code -p Module1
,bartycrouch code -p Module2
etc. but that is not sustainable.The text was updated successfully, but these errors were encountered: