Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement connection with redux. #2

Closed
flipace opened this issue Apr 28, 2016 · 4 comments
Closed

Implement connection with redux. #2

flipace opened this issue Apr 28, 2016 · 4 comments
Assignees
Milestone

Comments

@flipace
Copy link
Owner

flipace commented Apr 28, 2016

In my experience a big issue with redux can be the connection between data otw and the store.
In order to make it as easy as possible to use horizon with redux and react which is a common combination it would be great to have this connection of horizon data and redux store built right into horizon-react.

It seems like react-apollo does that and it could serve as inspiration for this feature.

Discussion about this connection can happen in here!

@flipace flipace self-assigned this Apr 28, 2016
@flipace flipace added this to the 1.0 milestone Apr 28, 2016
@flipace
Copy link
Owner Author

flipace commented May 3, 2016

I added basic redux features in the "next" branch. A couple of things will change - e.g. the way you pass props to subscribe it's now subscribe({ mapDataToProps: {}, mapStateToProps: ()=>({}) }) and you can pass all of redux's connect() options and they will be passed to redux's connect(). So there's no need to use connect and subscribe.

The next step is to utilize the redux store for storing query data and use it as some kind of cache.

@flipace
Copy link
Owner Author

flipace commented May 7, 2016

Base redux features are now in master on 0.2.0.

@flipace
Copy link
Owner Author

flipace commented May 11, 2016

Data propagation to redux store is now in the "next" branch. Polishing tbd.

@youfoundron
Copy link

@flipace,

Love what you're doing here, let me know if there's anything you need help with.

Cheers,
Ron

@flipace flipace closed this as completed Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants