Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoryPreview custom viewport sizes #83

Open
passhley opened this issue Mar 28, 2022 · 2 comments
Open

StoryPreview custom viewport sizes #83

passhley opened this issue Mar 28, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@passhley
Copy link
Collaborator

Could allow developers to pass custom viewport size options they can switch between in their storybook, such like if they want to be able to quickly click into a mobile view, etc.

Could look something like

return {
    roact = Roact,
    storyRoots = { 
        script.Parent.Components
    },
    viewports = {
        mobileSM = UDim2.fromOffset(800, 600),
        ultrawide = UDim2.fromOffset(3440, 1440),
    }
}
@vocksel
Copy link
Collaborator

vocksel commented Mar 28, 2022

Since users can mount the storybook in the viewport and use the device emulator to change screen size, would it still be valuable to bake this into the plugin?

@vocksel vocksel added the enhancement New feature or request label Mar 28, 2022
@passhley
Copy link
Collaborator Author

Hmm that is very true. My big plan for the plugin was to reduce the need for ever looking into studio as much as possible and being able to just keep it covering your whole screen and switching back and forth with your code editor. But yeah, it doesn't really seem like it'd be a huge thing or anything.

@vocksel vocksel removed the enhancement New feature or request label Dec 26, 2022
@vocksel vocksel added the enhancement New feature or request label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants