-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsupported vendor-prefixed style property webkitTransform #53
Comments
webkitTransform is the right name https://stackoverflow.com/questions/708895/how-to-set-the-style-webkit-transform-dynamically-using-javascript |
yes, I'm using chrome as well. Not sure why it gives that error on mine then. Just commenting that line it works, but not sure what the implications are. Also I have another issue when I build my project, it complains about not having react-native dependency, where I'm using it on the web. Even if I set the process.env it stills warns at building time. I'm using it within a meteor app. Any ideas? |
webKit transform is there to support browsers like UC. They don't understand transform property. Removing this warning will require a browser UA check which I don't to be inside the library. Maybe we can accept it as a prop. Regarding the process.env, does it just warns or the build actually fails. In case it does work are you able to get it to render everything fine? Share relevant part of webpack config if possible. Ideally webpack should've taken care of it. |
Please refer the link https://titobouzout.github.io/react/tips/inline-styles.html used for inline styles used in react. I think the property for inline style should be WebkitTransform (with a uppercase W). |
Thanks @twistedfork88 that'd solve the issue. @naqvitalha regarding the env variable, I'm not using webpack to bundle my project, so I don't have a config file. Even with the warning at build time, the project still runs, but it's a little annoying having that issue if I can prevent it somehow. I know other libraries like styled-components handle the separation btw native and web, or event rnw, where you can then create an alias for it depending where you are using it. |
thanks @twistedfork88, didn't know about this convention. @tafelito the idea with process.env was to keep the import location constant. The easiest solution that I can think of is to have something like Will try to get this out in next release. |
that'd great @naqvitalha thanks! |
@tafelito try version 0.0.2 . It's a beta. See if it fixes all of your issues. |
@naqvitalha 0.0.2 looks good! importing form /web did the job! Thanks! |
Great! It'll get release within a few days. |
Issue fixed in release 1.1.5 (https://github.com/Flipkart/ReactEssentials/releases/tag/1.1.5). Closing. |
Hi, I'm getting this warning error when loading the list on web
The issue seems to be in this line https://github.com/Flipkart/ReactEssentials/blob/8e7df4a56f14e9dfb6584e9b0a397f81df5e43aa/src/recyclerlistview/viewrenderer/web/ViewRenderer.js#L64
The text was updated successfully, but these errors were encountered: