Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android app no longer detects Flipper #335

Closed
RogueMaster opened this issue Aug 16, 2022 · 1 comment · Fixed by #340
Closed

Android app no longer detects Flipper #335

RogueMaster opened this issue Aug 16, 2022 · 1 comment · Fixed by #340
Labels
bug Something isn't working

Comments

@RogueMaster
Copy link

Describe the bug
Android app no longer detects Flipper on CFW with a name change for device so it doesn't transmit "Flipper" in the name.

To Reproduce
Steps to reproduce the behavior:

  1. Install Custom FW with line changes compiled in furi_hal_version.c so instead of Flipper it says anything else.
  2. Try to connect with Android app via bluetooth

Expected behavior
It connecting, like IOS app can. Possibly identifying other flippers with mac?
@RogueMaster RogueMaster added the bug Something isn't working label Aug 16, 2022
@skotopes
Copy link
Member

There are reasons why we use "Flipper" in the BLE device name, including ability to find flipper before establishing connection.

You are on your own with this issue.

@LionZXY LionZXY mentioned this issue Aug 26, 2022
Merged
LionZXY added a commit that referenced this issue Aug 26, 2022
@LionZXY
Search for devices by Mac address and by flipper name (Fix #335) (#340)
3081d2a 
**Background**

Now we are not looking for objects that do not match by name - some flippers may give an invalid name or mac address.

**Changes**

- Added new condition to the device filter by mac address
- Added `FlipperScannerImplTest`

**Test plan**

Try to find a flipper with an empty name

Fix #335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search for devices by Mac address and by flipper name (Fix #335) flipperdevices/Flipper-Android-App
3 participants
@skotopes @LionZXY @RogueMaster