-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Extension installation fails, quoting "fetch undefined". #397
Comments
Hi @eikopf and thanks for the bug report. (I have been away, hence the long response). What version of VSCode were you using? Newer version come with fetch built-in so there should not be any issue. It should just "work out of the box". |
Can you offer some more details? VSCode Version? Windows version? (We have multiple machines with Windows where it works currently, so any extra information would be useful). @sockmaster27 Do you have any ideas other than outdated VSCode? |
This was on VSCode 1.88.0 and Windows 22H2 (specifically build 22621.3447). I checked to see if I was wildly behind on VSCode versions, but installing the updates available only gave me 1.88.1. It's entirely possible that I happened to be on an older version of VSCode when I installed the Flix extension, and that restarting it just happened to also apply the update that included node-fetch in VSCode's version of node. Admittedly, I can't reproduce the bug (even by uninstalling node-fetch with npm), so my suspicion is that that's what happened. |
I'd suggest that if your Windows machines don't have this issue, then it's probably enough to call this expected behaviour for using an out-of-date version of VSCode. |
I strongly suspect this to be the case. |
I agree. The newer releases of the extension should declare the minimum supported VS Code version correctly. |
@magnus-madsen Is this possible? |
Not sure, but I would rather not mess with it. As I see it, this problem disappears with time and we can leave this ticket as documentation, if someone else should have the same problem. |
After installing the extension, and when opening a folder containing only an empty file called
Main.flix
, VSCode produces a vague error aboutfetch
being undefined.At least for me, the solution was to run
npm install --global node-fetch
and then completely restart VSCode. Is there a way to use a function fromnode-core
, or is this a VSCode-on-Windows issue?The text was updated successfully, but these errors were encountered: