Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kind of fixed the "crooked" lines. #4

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

xsirpreisx
Copy link
Contributor

I must admit, I have no real clue of what I'm doing. Haven't used much Github before. The last time I used version control software was in university, about 20 years ago :-D

So, I forked your fork of the power-flow-card and changed some of the paths that create the lines. I always thought the lines in the original energy dashboard where somewhat "crooked". I do think it looks a little better now.

I hope creating this pull request is the way to do things. Let me know if that's not how it's done.

Here is a before and after.

2023-03-24 20_39_54-Übersicht – Home Assistant

2023-03-24 20_48_07-Übersicht – Home Assistant

@xsirpreisx
Copy link
Contributor Author

I might have forgotten to also change them for the "has no battery users". I might try to do that in the next few days. After all it's basically just one number being changed in the path.

@flixlix flixlix merged commit c520a4c into flixlix:main Mar 24, 2023
@flixlix
Copy link
Owner

flixlix commented Mar 24, 2023

Thank you very much for contributing!
A PR is indeed the correct way of suggesting changes.
I tried changing the paths for configurations without batteries. It's not perfect in my opinion, but better than before.
I'm going to merge this PR, but feel free to propose new changes 👍

@elektrik216
Copy link

elektrik216 commented Apr 10, 2023

Thank you so much for this card! It will be good if the line from the battery toward the home circle be in other color than light blue. Its very difficult to see the ratio on the home circle when you got power from the battery and the grid in the same time. The colors need to be more in contrast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants