Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed db_migrator API for partitioning #8

Closed
laurenz opened this issue Feb 9, 2023 · 2 comments
Closed

Changed db_migrator API for partitioning #8

laurenz opened this issue Feb 9, 2023 · 2 comments
Assignees
@fljdin

Comments

@laurenz
Copy link

laurenz commented Feb 9, 2023

My commit cybertec-postgresql/db_migrator@1d85415 made some changes that affect this project:

  • the column expression in partitions and subpartitions has been renamed to key
  • for hash partitioning, values now only has to contain the remainder (I figure out the modulus from the size of the result set)

Sorry for the inconvenience.
@fljdin
Copy link
Owner

fljdin commented Feb 9, 2023

Hi Laurenz,

Latest PR commit has been sanitized to be compliant with db_migrator 1.0.0 and latest partitioning API.
It has been released as 0.2.0 🎉 20e2bf3

As you will see, it's doing an extra UPDATE in test file which performs a expression translate for partition key. I think it could be done directly into db_migrator.

@fljdin fljdin self-assigned this Feb 9, 2023
@laurenz
Copy link
Author

laurenz commented Feb 9, 2023

Feel free to send a patch for db_migrator.
I'd say you can close this issue, right?

@fljdin fljdin closed this as completed in 9cf6d0d Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fljdin fljdin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fljdin @laurenz