Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no dock on nix/win #1

Closed
verdverm opened this issue Mar 13, 2018 · 4 comments
Closed

no dock on nix/win #1

verdverm opened this issue Mar 13, 2018 · 4 comments

Comments

@verdverm
Copy link

FYI, the following line is breaking testing on non-Mac machines

frame/main/index.js

Line 19 in 7fa8bb4

process.env.TRAY_ONLY ? app.dock.hide() : windows.create()

Was able to get it running on Mac though!
@floating
Copy link
Owner

floating commented Mar 13, 2018 •
edited

Thanks @verdverm! Yes, app.dock.hide() is macOS only. I've been developing on macOS so there are some platform specific assumptions sill included. I'll be working to make everything platform agnostic very soon. Thanks for taking the time to run the demo!

@floating floating mentioned this issue Mar 13, 2018
Merged
@floating
Copy link
Owner

floating commented Mar 13, 2018 •
edited

@verdverm I've made the dock icon hiding conditional which should solve this particular issue, see #4.

@floating
Copy link
Owner

I've also tested and confirmed the demo is functional on Windows 10, see #2 if you run into any issues.

@floating
Copy link
Owner

Closing for now, let me know if you still have any problems running the demo.

@juanmacarrillo juanmacarrillo mentioned this issue May 4, 2022
Closed
@gpatkinson gpatkinson mentioned this issue Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@floating @verdverm