Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions regarding GUI #8

Open
akashkamboj opened this issue May 18, 2015 · 5 comments
Open

Some questions regarding GUI #8

akashkamboj opened this issue May 18, 2015 · 5 comments

Comments

@akashkamboj
Copy link

Hi Raymond Xie,

First of all nice work, putting this all together. I studied your code and it's very clean code. I tested your frontend app as well. And based on that I am creating an interactive frontend app. And I have reached to a certain stage, but faced a problem there.

In my GUI Let's say user1 bets and user2 calls and the chips moves to middle and become the pot chips. now when user1 bet again I want to only show the new bet chips (not all chips that he betted). That I am also able to achieve by storing it from the call, raise event.

But if somehow my window is refreshed or socket not responded then in that case there is no property to see the last bet user1 has placed / user2 has called. I see a pot_chips in room details but that's just an array of all the bets. It's not associated with user/seat.

I hope you understood my problem. If so, can you guide me to the right direction on how to achieve it.

Also I have some suggestions/improvements that I can contribute to this project. How can I do that? Shall I send you pull request or create a discussion board.

Thanks in Advance.

@floatinghotpot
Copy link
Owner

Hi Akash, I think the pot_chips can be changed to an array of 2 elements array, first is seat, second is chip.

Your contribution is appreciated, pull request or ideas, bug reports, all welcome.

@akashkamboj
Copy link
Author

hi @floatinghotpot

As I progress, i see more and more issues. that will be hard to achieve just by pull requests, a few places needs overall up-down changes.

Here are some of the things for your reference:

  1. dealer_seat is never updated.
  2. all_in have issues.
  3. raise range shouldn't be whatever the last bet is.
  4. game STATE can be better as well as we should send game STATE in the response.
  5. some of the code mismatch... i.e. checking ret.inseats on gamestart is useless for dealer_button bcoz there's no response like that.

and many more.

Are you having free time to work on this now? If you want we can have skype chat and discuss things and work on this simultaneously.

@floatinghotpot
Copy link
Owner

@akashkamboj please create issue trackers on github, so that we can follow up and resolve them one by one.

we can also discuss the issues via skype, my skype id is: floatinghotpot

@zilveer
Copy link

zilveer commented Jul 24, 2017

@akashkamboj did u ever develop a GUI for this?

@nitinmukesh
Copy link

These issues are still there. Please do we have any fix for these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants