Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all theme colors variables #188

Closed
jackparmer opened this issue Jan 31, 2023 · 0 comments
Closed

Make all theme colors variables #188

jackparmer opened this issue Jan 31, 2023 · 0 comments
Assignees
@Orisu179
Labels
good first issue Good for newcomers tech-debt

Comments

@jackparmer
Copy link
Collaborator

There should be no hardcoded HEX or RBG colors like here:

https://github.com/flojoy-io/flojoy-desktop/blob/main/src/feature/common/defaultPlotLayout.ts#L2

These should all be templated variables so that theme colors can be tweaked easily.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Orisu179 Orisu179

Labels
good first issue Good for newcomers tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jackparmer @Orisu179 @dev-nested