Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ge25519_double_scalarmult_vartime() unfinalized #31

Open
user8547 opened this issue May 4, 2016 · 0 comments
Open

ge25519_double_scalarmult_vartime() unfinalized #31

user8547 opened this issue May 4, 2016 · 0 comments

Comments

@user8547
Copy link

user8547 commented May 4, 2016

ed25519-donna.patch.txt

I am using ed25519-donna not for EdDSA, but for general point operations using ed25519 curve.

I noticed that ge25519_double_scalarmult_vartime() does not correctly finalize the result.
If I try to add the result to some other point then I get an incorrect result (not a problem for ed25519.c).
It seems that this is because ge25519_double_scalarmult_vartime() lacks ge25519_p1p1_to_full(r, &t); at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant