Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_KenBurnsState didn't handle widget update #4

Closed
sanekyy opened this issue Aug 4, 2020 · 1 comment · Fixed by #5
Closed

_KenBurnsState didn't handle widget update #4

sanekyy opened this issue Aug 4, 2020 · 1 comment · Fixed by #5

Comments

@sanekyy
Copy link
Contributor

sanekyy commented Aug 4, 2020 •
edited

If parent/holder of KenBurns widget will change single to multiple or vise versa there will be some errors related with animation loops and missed handling of widget update.

single -> multiple:

#0      List.[] (dart:core-patch/growable_array.dart:177:60)
#1      _KenBurnsState._buildChild (package:kenburns/kenburns.dart:313:63)
#2      _KenBurnsState.build.<anonymous closure> (package:kenburns/kenburns.dart:296:20)

multiple -> single

NoSuchMethodError: The method '%' was called on null. Receiver: null Tried calling: %()
_KenBurnsState.fire (_KenBurnsState.java:259)

I fixed it in PR #5.
@sanekyy sanekyy mentioned this issue Aug 4, 2020
Merged
@otopba
Copy link

otopba commented Aug 4, 2020

Nice fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle widget updates sanekyy/Flutter-KenBurns
2 participants
@otopba @sanekyy