Memory leak in MaterialViewPagerHelper

[MGaetan89]

I started using https://github.com/square/leakcanary to find potential memory leaks in my application.

Turns out there is one in your great library in MaterialViewPagerHelper. Indeed, it holds a static HashMap that is never cleared. Maybe you could add a method to clear the content of that map when the Activity/Fragment is destroyed?

[florent37]

Yes, I thinks it would be usefull.

Do you want to do in and send a pull request ?

if not I will do it myself, just to prevent doing same work twice

[MGaetan89]

I can't work on this for the next two weeks.
I can have a look then if you haven't fixed it yet.

[florent37]

I fixed it in 1.0.3.1 can you check please ? :)

[florent37]

MaterialViewPager.java

@Override
protected void onDetachedFromWindow() {
    MaterialViewPagerHelper.unregister(getContext());
    super.onDetachedFromWindow();
}

MaterialViewPagerHelper.java

public static void unregister(Context context) {
    if(context != null)
        hashMap.remove(context);
}

[MGaetan89]

It looks like there is no issue now.
Thanks for the quick fix 😄

[florent37]

Thanks for your reporting 👍