Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add me to collaborators #284

Closed
nurse opened this issue May 26, 2016 · 4 comments
Closed

Add me to collaborators #284

nurse opened this issue May 26, 2016 · 4 comments

Comments

@nurse
Copy link
Collaborator

nurse commented May 26, 2016

Hi, @flori

Ruby bundles json.gem and we sometimes change ext/json to follow latest Ruby changes and suppress compiler warnings and so on.

Recently some PRs are not merged yet.
Such difference between upstream and downstream is not so good.
I want to merge such PRs by myself.

Could you add me to collaborators?

Thanks,

@perlun
Copy link
Contributor

perlun commented May 31, 2017

I won't say whether @nurse is a suitable collaborator or not (I don't know him/her), but it's quite clear from looking at this project that it would make sense to have more collaborators, to keep up with the pace of pull requests etc.

@flori what is your opinion?

@nurse
Copy link
Collaborator Author

nurse commented Jun 1, 2018

@flori ping!
Recently I and @hsbt sometimes asked about json.gem's activity because we are managing bundled json.gem in Ruby repository.
Could you add me and @hsbt as collaborators of this repo and give privilege to gem push?

@nurse
Copy link
Collaborator Author

nurse commented Oct 20, 2018

@flori Note that I want to change json.gem only for following CRuby's API changes.
Not intend to add new features.

@nurse
Copy link
Collaborator Author

nurse commented Oct 22, 2018

I was added to collaborator, thanks!

@nurse nurse closed this as completed Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants