Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strict option is broken for pure-Ruby implementation #584

Open
eregon opened this issue May 9, 2024 · 1 comment · May be fixed by #585
Open

strict option is broken for pure-Ruby implementation #584

eregon opened this issue May 9, 2024 · 1 comment · May be fixed by #585

Comments

@eregon
Copy link
Contributor

eregon commented May 9, 2024

In this repo:

$ bundle exec ruby -rjson/pure -e 'p JSON.dump({"a" => 1}, strict: true)'
/home/eregon/code/json/lib/json/pure/generator.rb:358:in `block in json_transform': Integer not allowed in JSON (JSON::GeneratorError)
	from /home/eregon/code/json/lib/json/pure/generator.rb:353:in `each'
	from /home/eregon/code/json/lib/json/pure/generator.rb:353:in `json_transform'
	from /home/eregon/code/json/lib/json/pure/generator.rb:337:in `to_json'
	from /home/eregon/code/json/lib/json/pure/generator.rb:289:in `generate'
	from /home/eregon/code/json/lib/json/common.rb:306:in `generate'
	from /home/eregon/code/json/lib/json/common.rb:627:in `dump'
	from -e:1:in `<main>'

But of course Integer should be allowed.

The bug seems clear when looking at

json/lib/json/pure/generator.rb

Lines 357 to 363 in 4f876a8

if state.strict?
raise GeneratorError, "#{value.class} not allowed in JSON"
elsif value.respond_to?(:to_json)
result << value.to_json(state)
else
result << %{"#{String(value)}"}
end

json/lib/json/pure/generator.rb

Lines 400 to 406 in 4f876a8

if state.strict?
raise GeneratorError, "#{value.class} not allowed in JSON"
elsif value.respond_to?(:to_json)
result << value.to_json(state)
else
result << %{"#{String(value)}"}
end

It was added in #519 but with too few tests so they didn't catch this bug.
@byroot / @casperisfine Could you fix this?
@eregon eregon mentioned this issue May 9, 2024
Merged
casperisfine pushed a commit to casperisfine/json that referenced this issue May 9, 2024
@byroot
JSON::Pure fix strict mode
8156994 
Followup: flori#519
Fix: flori#584
@casperisfine casperisfine linked a pull request May 9, 2024 that will close this issue
Open
@casperisfine
Copy link

#585

casperisfine pushed a commit to casperisfine/json that referenced this issue May 9, 2024
@byroot
JSON::Pure fix strict mode
db37392 
Followup: flori#519
Fix: flori#584
casperisfine pushed a commit to casperisfine/json that referenced this issue May 9, 2024
@byroot
JSON::Pure fix strict mode
937900c 
Followup: flori#519
Fix: flori#584
casperisfine pushed a commit to casperisfine/json that referenced this issue May 9, 2024
@byroot
JSON::Pure fix strict mode
3652866 
Followup: flori#519
Fix: flori#584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JSON::Pure fix strict mode casperisfine/json
2 participants
@eregon @casperisfine