Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeTray should have a top edge param #107

Closed
florianfesti opened this issue Jan 2, 2019 · 3 comments
Closed

TypeTray should have a top edge param #107

florianfesti opened this issue Jan 2, 2019 · 3 comments

Comments

@florianfesti
Copy link
Owner

TypeTray only has two options for the top: Straight edge or closed top (using FingerJointEdge f).

This leaves at least the StackableEdge available for the bottom unmatched. One could argue the top edge should actually be freely selectable similar to the UniversalBox. Otoh this will make the UniversalBox redundant - which may be a good thing...

See also https://hackaday.io/project/10649-boxespy/discussion-118236

@Blancanegra
Copy link

Please keep UniversalBox, I found it very useful!

Maybe you should add inner divisions to UniversalBox, or lid support for TypeTray... crossing worlds! :)

@florianfesti
Copy link
Owner Author

I already added a top_edge param to the TypeTray (c0a782b). But the change is not in the web instance yet.
I will probably keep the UniversalBox to not confuse users too much, although the TypeTray can (almost) do everything the UniversalBox can plus the inner walls.

@florianfesti
Copy link
Owner Author

Ok, I was still missing the lids that belong to the top_edges. That's fixed now and already online. I will probably change the sides of the outside walls to the same f-F pattern as the universal box. But that's out of scope of this ticket. Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants