Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoveTailJointCounterPart in CompoundEdge #3

Closed
MAKOMO opened this issue Apr 22, 2016 · 6 comments
Closed

DoveTailJointCounterPart in CompoundEdge #3

MAKOMO opened this issue Apr 22, 2016 · 6 comments

Comments

@MAKOMO
Copy link

MAKOMO commented Apr 22, 2016

        self.open(50, 50)
        x = y = 10
        r = 0
        h = 46
        sep = 20 # 12
        self.surroundingWall(x,y,r,h,
            left=edges.CompoundEdge(self,["D","e"], [h-sep,sep]),
            right=edges.CompoundEdge(self,["e","d"], [sep,h-sep]))
        self.close()

renders

screen shot 2016-04-22 at 17 11 07

The left edge is not what I expected. The right edge looks fine.

@MAKOMO
Copy link
Author

MAKOMO commented Apr 22, 2016

Oh, and if I add bottom='F'I expected the total hight to increase by thickness. Isn't the height argument interpreted as the inner height? At least I was under the impression that some commits before that was the case. I might be wrong.

@ffesti
Copy link
Contributor

ffesti commented Apr 26, 2016

Well, the surroundingWall was not really ready to have fully parametrized edges. Also nice catch on the "F" width mess up. Both should be fixed now.

@MAKOMO
Copy link
Author

MAKOMO commented Apr 26, 2016

I confirm that the "F" width is back to normal with our latest commit. The compound left edge improved somewhat, but does still not render as I would expect it.

screen shot 2016-04-26 at 21 14 04

Why is there this 90 degree turn to the inside after the "D" edge? I would have expected just a straight line as on the right side.

@MAKOMO
Copy link
Author

MAKOMO commented Apr 26, 2016

Ah, now I found where that 90 degree turn to the inside happens. It is in CompoundEdge/call in the elif part. However, I get what I expect (for this example) if I comment the "def startwidth" in DoveTailJointCounterPart.

@florianfesti
Copy link
Owner

Yup, the DoveTailJointCounterPart should be width zero so that the DoveTailJoint doesn't need any length of the surrounding wall. Fixed now.

@MAKOMO
Copy link
Author

MAKOMO commented Apr 26, 2016

Yes, I think this issue is now closed, however, I now have another "CompoundEdge issue" in another place. I will investigate and potential have to open another issue...

@MAKOMO MAKOMO closed this as completed Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants