Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-box paths #40

Closed
objectiveSee opened this issue May 15, 2017 · 5 comments
Closed

Support for non-box paths #40

objectiveSee opened this issue May 15, 2017 · 5 comments

Comments

@objectiveSee
Copy link

Hey! This library looks interesting. I am trying to find software that can generate the walls for a box with a complicated shape. The "box" is actually a heart shaped path (see image, which includes my own box notches). Do you think your software would work for this? I have seen other tools not work because of the type of corner marked with a green arrow. I wrote my own "notcher" library in JS but it is not as robust as I had hoped.

foo

@florianfesti
Copy link
Owner

The problem with this corner is that the edge is shorter than they would be nominally. The easiest way out is using only finger edges on the top and bottom parts and have the "F" style edge on the top and bottom of the rectangular side walls.

@florianfesti
Copy link
Owner

Hmm, this still doesn't really solve the issue.
.edgeCorner() might just do the "right" thing to make this work - although not in a nice way: elongating the edges at the corner inward one thickness.

@florianfesti
Copy link
Owner

The right solution would probably be something like Boxes.polyline() but with edges. Either one Edge type all around or giving type and length tuples. The same code would generate both the outline and the side walls.

@florianfesti
Copy link
Owner

Ok, 7aec26e adds polygonWall() and polygonWalls() which do exactly this - including support for rounded corners with flex.
As an example ce8576d adds a new heart box generator.
Will updated the web instance after a bit more testing.

@florianfesti
Copy link
Owner

HeartBox makes use of this new feature - although using flex for a smoother outline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants