Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical alignment issues #21

Closed
foobear opened this issue Apr 29, 2020 · 4 comments
Closed

Vertical alignment issues #21

foobear opened this issue Apr 29, 2020 · 4 comments
Milestone

Comments

@foobear
Copy link

foobear commented Apr 29, 2020

The font's vertical alignment is too far up. This started with version 1.1.4, version 1.1.3 was still fine.

Here is a minimal example for versions 1.1.3, 1.1.4 and 1.1.6 (latest):
https://glitch.com/~space-grotesk-alignment-test

This is how it looks on my Chrome on Linux:
image

When checking other browsers, I also encountered inconsistent rendering across different platforms and browsers that varies much more than it should. Note how 1.1.6 sometimes has no vertical spacing and how 1.1.4's vertical alignment is correct on some platforms while it forces its lines to be too tall.

Since version 1.1.3 rendered consistently and was aligned properly, I'm hoping this to be a change in your toolkit that can easily be fixed. Fingers crossed. :)

Attached are some screenshots I took using Browserstack. Please ignore the borders and bad sizing.

Windows Chrome:
bs_win10_Chrome_81 0

Windows Firefox:
bs_win10_Firefox_75 0

OSX Chrome:
bs_maccat_Chrome_81 0

OSX Firefox:
bs_maccat_Firefox_75 0

OSX Safari:
bs_maccat_Safari_13 0

@mightybart
Copy link
Collaborator

Addressed in v2 branch, not sure about the final approach yet. But this is a high priority.

@foobear
Copy link
Author

foobear commented May 18, 2020

Thanks for looking into it! v2 looks better, I might even use that one for production. 😉

Note that rendering is still a bit inconsistent across platforms, e.g. Chrome on Windows and OSX render differently, though it's not too significant.

Updated the example to include v2 and a separate page with some Bootstrap-styled buttons.

@mightybart
Copy link
Collaborator

mightybart commented Sep 27, 2020

One last adjustment before final 2.0.0 release:

VM-single

VM-multi

@vv-monsalve please can you check and confirm for the very last time? 🙏

@vv-monsalve
Copy link
Contributor

I just run QA on the latest files at commit 743ffa3, and everything is reported ok, with 0FB fails.
I'll proceed to PR from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants