Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified autoincremented integer ID migration #61

Closed
florimondmanca opened this issue Jun 29, 2019 · 2 comments · May be fixed by #63
Closed

Simplified autoincremented integer ID migration #61

florimondmanca opened this issue Jun 29, 2019 · 2 comments · May be fixed by #63
Labels
help wanted Extra attention is needed
Milestone

Comments

@florimondmanca
Copy link
Owner

florimondmanca commented Jun 29, 2019

Is your feature request related to a problem? Please describe.
Once #60 is solved, we should be able to provide a much simpler migration for the integer ID.

Describe the solution you'd like
Update AbstractAPIKey by dropping the custom id column, and generate a migration which simply drops the current id field and adds the autoincremented one.

As hinted in #42 (comment), adding/populating the new ID column and dropping the old ID column should be done in two separate migrations. This will allow users to take action in a state where both IDs exist.

We'll still need a migration guide for users with models referring to an APIKey model. See #48

Describe alternatives you've considered
/

Additional context
See #40 and #41 for the previous implementation

@florimondmanca florimondmanca added the enhancement Enhancement of an existing feature label Jun 29, 2019
@florimondmanca florimondmanca added this to the 2.0 milestone Jun 29, 2019
This was referenced Jun 29, 2019
@florimondmanca
Copy link
Owner Author

I'd really like to get the PK migration over the line as 2.0. There's still #63 but I'm missing some time currently to implement this. If this is blocking some users, any help/PRs would be gladly appreciated. :-)

@florimondmanca florimondmanca added help wanted Extra attention is needed and removed enhancement Enhancement of an existing feature labels Dec 26, 2019
@florimondmanca
Copy link
Owner Author

Closing as this is now out of date. Will open another issue for PK migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant