Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Currency to Language #210

Closed
Glitchy-Tozier opened this issue Jan 19, 2021 · 4 comments · Fixed by #561
Closed

Adapt Currency to Language #210

Glitchy-Tozier opened this issue Jan 19, 2021 · 4 comments · Fixed by #561
Assignees
Labels
proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement
Milestone

Comments

@Glitchy-Tozier
Copy link
Collaborator

Currently, even though I use the German FlorisBoard, the currency-symbol on the first symbol-keyboard still is the dollar ($).
I think, it would be best to change this to , at least in the case of German and a couple of other European languages.

It might be a good idea to do the same thing and adapt the currency for other languages. (¢, ¥, £)...

Of course that would result in redundancy on the second symbol-keyboard. Meaning the keys there should also be adapted.

@Glitchy-Tozier Glitchy-Tozier added the proposal A proposal for a new feature or an enhancement label Jan 19, 2021
@patrickgold
Copy link
Member

The idea is good and if I am not mistaken it has already been mentioned somewhere here, I think though that binding this to a specific subtype is not sufficient, as I often write English text on phones but still need the Euro symbol. So I will probably make subtype specific symbols (especially for Arabic, Russian, etc.) and decouple the currency keys to a separate preference.

@patrickgold patrickgold added the proposal-accepted An accepted proposal for a new feature or an enhancement label Jan 19, 2021
@Glitchy-Tozier
Copy link
Collaborator Author

Sounds like a plan!

@alensiljak
Copy link

alensiljak commented Feb 20, 2021

I also use a different currency than what is the default for the language.
Consider also the case when multiple languages are in use. What would be the currency symbol used by default then?
I normally have three languages active at all times. Moreover, I often type words in one language as a part of a conversation in another.

@patrickgold
Copy link
Member

Above PR adds the ability to dynamically choose a "currency set" for each subtype. Each currency set consists of 6 currency symbols, which together fill all base character and popup slots both on the symbols and symbols2 layout. For each default subtype, I've also tried to find the best matching default currency set, which is pre-selected when adding a subtype (can be freely changed though). Will be released in v0.3.10-beta05 this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal for a new feature or an enhancement proposal-accepted An accepted proposal for a new feature or an enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants