Repeating input

[yant0]

Short description

Clicked once, repeated until pressed again. Is this a new feature?

Steps to reproduce

1. Type things for a while
2. Catch the bug occur

Environment information

• FlorisBoard Version: 0.3.13 beta-3
• Install Source: Fdroid
• Device: Asus Zenfone Max pro m1
• Android: 9 stock

[zer0fl0w]

confirmed here. same issue.

[Glitchy-Tozier]

Gould you specify? What happens? Do some buttons rapid-fire when you hold them?

[patrickgold]

Clicked once, repeated until pressed again. Is this a new feature?

Nope, that's definitely a bug, one which I am absolutely not able to reproduce though.

Now as you opened an issue for this, could you specify:

• for which keys this happens (only delete, arrow etc.) or all keys like letters numbers etc.
• does this bug occur consistently
• does it happen with a single fast tap or only when holding down a key longer

Thanks in advance for answering these points, this would help me much in finding the culprit for this nasty bug!

[yant0]

i think the bug is only with delete and arrow keys.
I was writing text and used delete and arrow keys multiple times and i see the bug 5-7 times when writing. I also find this bug right after updating beta and typing on search app.
Bug happened with fast tap, not sure if it can be replicated with long tap.

[zer0fl0w]

can confirm. it is mainly the back/delete key.
you misstype something in inputfields, want to delete the last character(s) quick and away goes everything you've just written until you fast enough press again deletekey but it not stops everytime on first try.

also i often have to doubleclick to get numbers row and shift / unshift. sometimes it does not go back after capital and stays locked in capital without really being locked in caps.

oh man, i hope what i just wrote makes sense and is understandable.

[Glitchy-Tozier]

@zer0fl0w So you click on the delete key once and it just keeps deleting?

[zer0fl0w]

sometimes (rare), but in most situations it happens after pressing 2 or more times. i eventually pause between first and following clicks/taps, like slow and not doubleclick, but it randomly still fires the constant backspace.

i also have the feeling that it is sometimes app-dependend.
i.e. in termux i almost always have to doubletap enter to send a cmd. it is weird.

it often feels like the settings in windows where you can set if you want to open links/folders with single- or doubleclick.

at least for shift, numberkey and enter.

i think it started with beta02, not sure tho.

[teemue]

I can confirm this, I have noticed it happening on delete-key. Really annoying.

[teemue]

I've noticed that this happens often in the web browser, when web site is loading and at the same time i'm typing a new address. Also on other situations where the OS/CPU seems to be processing something.

[rex07]

Same here is a video
https://user-images.githubusercontent.com/13156001/126200918-537eef6f-e961-4c58-81e3-f197239567b3.mp4

[rex07]

Some times the delete button get stuck
Even if you type any letter it delete it instantly

[teemue]

Same here is a video
https://user-images.githubusercontent.com/13156001/126200918-537eef6f-e961-4c58-81e3-f197239567b3.mp4

That shows exactly what happens. For me, It seems to hang sometimes even after one click of backspace button. Could this be related to the overall performance of the device (I have pretty old Nokia 5.1) @patrickgold ?

[josephbadow]

Just wanted to +1 this on the backspace key to delete text. In my case it happens when I hold the key to delete two or three words. Then it will delete a few more than it should and it actually feels as if there is some kind of lag. Like when you have a CPU heavy task running and confirm a dialog and it takes a couple of seconds until the confirmation is recognized by the system.

[Glitchy-Tozier]

@josephbadow If you're using version v0.3.12 (the newest non-beta version), your problem may be connected to #883.

[josephbadow]

@josephbadow If you're using version v0.3.12 (the newest non-beta version), your problem may be connected to #883.

@Glitchy-Tozier Dang, looks like I didn't search properly 🙈 #883 looks a lot more related to my issue. Thanks for the heads up.

[jm355]

Just wanted to chime in and say I'm getting the same issue with the delete key. Usually happens if I'm alternating between swyping and tapping to tap and need to delete something, but it seems pretty random

[GoRaN909]

This bug is happen when you typing fast and when you tap on the Delete button at the end of a paragraph i think that appears after version 3.10 and newer versions till now.

[ElishaAz]

I managed to actively reproduce this error on my device:

• Get a very large file (I used "2mb text file" from https://www.learningcontainer.com/sample-text-file/# )
• Open it in a text editor (I used TEdit )
• Insert a few letters
• Hit backspace
• The keyboard doesn't stop deleting.

It looks like the 'key up' for the backspace key is not getting registered when a lot of resources are being used.
Maybe because of the backspace key's gesture support?

[patrickgold]

@ElishaAz Thanks for your comment I got a few ideas how to reproduce the bug and I am finally able to reproduce it :)

So it seems that this bug is dependent how busy FlorisBoard is and how much your device CPU can handle at once. Because of this I cannot reproduce the bug on my physical OnePlus 7T, even not for 10MB text files.

The good thing is I also have access to other physical devices, which are a lot weaker. The first one I tried was the Samsung Galaxy A20e - and bingo it worked (and lagged a lot with the 2 MB text!). I reproduced this in the Samsung Notes app, where I pasted 100kB of data 20 times, so the app you use isn't that much important. For me it is most consistently reproducible when quickly double-tapping delete in text fields with a lot of data.

As I can now finally reproduce the bug (at least for one option), I can start go debugging and fixing the bug.

[patrickgold]

Ok after some quick debugging it seems the keyboard logic eats the second UP event of KeyCode.DELETE for lunch, thus the delete key technically stays down in the input dispatcher and is repeated. Very strange why this is happening though, probably a non-thread-safe access to the current pressed state. Will further investigate.

[patrickgold]

Above PR is a draft fix for the repeating input bug. It would be very helpful for me if some of you could install the debug artifact of the PR to check if the bug has been fixed (the debug version installs separately and won't affect your main installation). On my Samsung device I wasn't able to reproduce the bug anymore, but this alone is not enough to validate if this bug has been fixed. Thanks in advance!

[rex07]

It's fine now if i found it happening again i will let you know.

[patrickgold]

I've merged #1147 into master. The fix for the repeating input will thus be in the beta09 release, which will be published either tomorrow or on Sunday. Thanks all for reporting and helping out to fix this bug!