Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not display most recent build when retriggering #3

Closed
flosell opened this issue Aug 29, 2015 · 6 comments
Closed

Does not display most recent build when retriggering #3

flosell opened this issue Aug 29, 2015 · 6 comments

Comments

@flosell
Copy link
Owner

flosell commented Aug 29, 2015

Consider this scenario:

  • build 4 has successfully run build-steps foo and bar with bar being after foo in the pipeline
  • build 5 runs afterwards, also running completing foo
  • Now we retrigger bar on build 4
  • build 6 appears, with duplicates of the foo results. because cctray orders by build-number, cctray now shows build 6 for foo when this build 6 never actually ran foo but is just there for pipeline consistency. We'd expect build 5 to be the build cctray uses for foo.

Possible fix: sort by :first-updated-at instead of build number.
We could also sort by :most-recent-update-at but this might lead to strange flapping when two builds run a step at the same time.

@SimonMonecke
Copy link

We still have this bug (v. 0.4.0):

screenshot_2015-09-15_13-13-09
screenshot_2015-09-15_13-13-39
screenshot_2015-09-15_13-14-11

@flosell
Copy link
Owner Author

flosell commented Sep 16, 2015

Hmm, this is interesting. Is build 6 you retriggering the in-rqp-workspace? Or some nested step?

Could you post the timestamps (first-updated-at, most-recent-update-at) for the build steps that are relevant (e.g. the one you retriggered, its parents, steps near it, ...)? You'll find them on the api/builds/<buildnumber>/ endpoint or by just expanding the complete step result on a build step.

@flosell flosell reopened this Sep 16, 2015
@SimonMonecke
Copy link

I think only Build 5 and 6 are important:

Build 6 ("retrigger-mock-for-build-number": 5):

  • in-rqp-workspace:
    ** "status": "success"
    ** "first-updated-at": "2015-09-15T10:40:23.464Z"
    ** "most-recent-update-at": "2015-09-15T10:57:54.046Z"

Build 5:

  • in-rqp-workspace:
    ** status": "failure"
    ** "first-updated-at": "2015-09-15T10:40:23.464Z"
    ** "most-recent-update-at": "2015-09-15T10:45:01.465Z"

If you retrigger build 5 the new build will have the same "first-updated-at" value. You use this parameter to sort the builds.

@flosell
Copy link
Owner Author

flosell commented Sep 20, 2015

I think I now reproduced your behavior, it occurs when retriggering a child of in-rqp-workspace, right? It seems to be caused by a bug in LambdaCD (flosell/lambdacd#56)

@flosell
Copy link
Owner Author

flosell commented Sep 20, 2015

Should be fixed in the next release of LambdaCD

@SimonMonecke
Copy link

perfect, thank you!

I have tried to figure out what step my colleague has trigged but he did not know exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants