Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML rendered axis labels missing width property in flot 0.8 #1019

Closed
sabregreen opened this issue Apr 16, 2013 · 1 comment
Closed

HTML rendered axis labels missing width property in flot 0.8 #1019

sabregreen opened this issue Apr 16, 2013 · 1 comment
Assignees
@dnschnur
Labels
bug
Milestone
Release 0.8.1

Comments

@sabregreen
Copy link

When using HTML rendered axis labels, the width property that was present in 0.7 is missing in 0.8. This prevents multiline text for HTML rendered axis labels. Screenshots showing attached.

flot7
flot8
@ghost ghost assigned dnschnur Apr 17, 2013
@dnschnur
Copy link
Member

I revisited the 0.7 source and confirmed that this is indeed a regression. The width was set as an optimization to avoid having to measure individual labels. I didn't realize that it also had the side-effect of enabling multi-line text, and left that code out when reworking the text internals for 0.8.

I'm almost done with a patch to restore the old behavior. I'll need to spend a little time testing, but should have it merged by this weekend.

dnschnur referenced this issue May 5, 2013
@dnschnur
Restore 0.7's maximum width for x-axis labels.
571d86e 
Flot 0.7 calculated x-axis label dimensions by assigning each label a
fixed width, then measuring the height as determined by the browser.  A
side-effect of this technique is that x-axis label divs received a fixed
width.  The rewrite of the text system in 0.8 accidentally removed this
feature; this patch restores it.
@dnschnur dnschnur closed this as completed May 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnschnur dnschnur

Labels
bug
Projects
None yet
Milestone
Release 0.8.1
Development

No branches or pull requests
2 participants
@dnschnur @sabregreen