Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: Support for colors in the highlight() function. #247

Closed
dnschnur opened this issue Sep 28, 2012 · 3 comments
Closed

Patch: Support for colors in the highlight() function. #247

dnschnur opened this issue Sep 28, 2012 · 3 comments

Comments

@dnschnur
Copy link
Member

Original author: gustav.l...@gmail.com (June 04, 2009 19:34:56)

Hi, I recently made a change to add support for color in the highlight()
function, attached is the patch that I made.

Feel free to include it in Flot if you find it useful.

Original issue: http://code.google.com/p/flot/issues/detail?id=168

@dnschnur
Copy link
Member Author

From davorin....@gmail.com on June 25, 2009 14:13:49
shouldn't it be multiplying the opacity with 1 instead of 0.5?

var fillStyle = parseColor(color).scale(1, 1, 1, 1).toString();

if I put 1 instead of 0.5 the color is ok, otherwise it just mixes with the
underlying bar color which looks nasty.

@dnschnur
Copy link
Member Author

From olau%iol...@gtempaccount.com on July 04, 2009 17:12:21
Interesting idea, thanks for submitting the patch! I have too much on my plate right
now but something to check out at a later date.

@dnschnur
Copy link
Member Author

From dnsch...@gmail.com on July 16, 2012 16:02:27
Done by merging pull request #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant