Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Lines get rendered 1px too far left #87

Closed
dnschnur opened this issue Sep 28, 2012 · 8 comments
Closed

Graph Lines get rendered 1px too far left #87

dnschnur opened this issue Sep 28, 2012 · 8 comments

Comments

@dnschnur
Copy link
Member

Original author: ja...@shaped.ca (December 07, 2007 13:25:00)

If you look closely at any rendered graph, the lines start on the left
border not inside it.

Original issue: http://code.google.com/p/flot/issues/detail?id=8

@dnschnur
Copy link
Member Author

From olau%iol...@gtempaccount.com on December 07, 2007 15:05:59
Well spotted! It's because of an ugly hack I never removed completely fully. I've
done that now. The fix will be in the next release which I'm uploading now.

@dnschnur
Copy link
Member Author

From ja...@shaped.ca on December 07, 2007 15:56:00
Sweeeeet. :)

@dnschnur
Copy link
Member Author

From ja...@shaped.ca on December 07, 2007 16:08:32
Hi,

Your fix has not completely solved the problem, though obviously it has helped.

As you can see, it's still leaking past the border. Perhaps you can render the border
over top of the lines instead of vice versa.

http://shaped.ca/flot.jpg

As you can see though, your graph looks nice in my application. :)

@dnschnur
Copy link
Member Author

From olau%iol...@gtempaccount.com on December 07, 2007 16:29:31
The remainding overlap is on purpose, it's a stylistic artifact. :-)

@dnschnur
Copy link
Member Author

From ja...@shaped.ca on December 07, 2007 22:17:17
And your stylistic artifact takes away from the design of my interface.

Provide an option or fix it, or I will have to, no offense but that kind of a
response isn't acceptable for publicly released works. :(

@dnschnur
Copy link
Member Author

From olau%iol...@gtempaccount.com on December 10, 2007 11:38:59
If you can figure out how to avoid the overlap with everything still looking fine,
feel free to submit a patch.

I don't think drawing the grid outline on top of the graphs is a good solution,
because it means that we'd have to shuffle the code around to still have points on
top of the outline. So I suggest you take a look at the drawSeriesLines and the
embedded plotLine functions.

@dnschnur
Copy link
Member Author

From olau%iol...@gtempaccount.com on January 13, 2009 13:13:36
I just changed the border to be like a CSS border. So the overlap is gone now.

@dnschnur
Copy link
Member Author

From ja...@shaped.ca on January 13, 2009 22:10:09
I'll check it out! Thanks for fixing this even though it's a 1+ year old bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant