Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NowJS is improperly served when it is injected after the document has loaded. #26

Closed
humanchimp opened this issue Mar 30, 2011 · 1 comment
Closed

NowJS is improperly served when it is injected after the document has loaded. #26

humanchimp opened this issue Mar 30, 2011 · 1 comment

Comments

@humanchimp
Copy link

If you include the /nowjs/now.js script in the HTML, everything works fine. The problem arises if you want to inject the script after the page has loaded for some reason.

Suggested fix in lib/nowServerLib.js at line 289

-      if(request.url === "/nowjs/now.js") {
+      if(request.url.split('?')[0] === "/nowjs/now.js") {
@ericz
Copy link
Contributor

ericz commented Mar 30, 2011

Thanks for bug report and fix.

@ericz ericz closed this as completed Mar 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericz @humanchimp