Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: move hello-world plugins to their own repository #96

Closed
JohnTheGr8 opened this issue Jun 30, 2020 · 2 comments
Closed

Suggestion: move hello-world plugins to their own repository #96

JohnTheGr8 opened this issue Jun 30, 2020 · 2 comments
Assignees
@JohnTheGr8
Labels
question/discussion Further information is requested/discussion about a topic

Comments

@JohnTheGr8
Copy link
Member

JohnTheGr8 commented Jun 30, 2020 •
edited

I see no reason to ship the 3 hello-world plugins with the launcher... I suggest that we move them to a separate repository, something like plugin-samples, and simply mention them in the plugin-development docs.

For a potential plugin developer looking for a sample plugin to base their work on, it would be much simpler this way.
@JohnTheGr8 JohnTheGr8 added the question/discussion Further information is requested/discussion about a topic label Jun 30, 2020
@JohnTheGr8 JohnTheGr8 self-assigned this Jun 30, 2020
@jjw24
Copy link
Member

jjw24 commented Jun 30, 2020

Agree

@JohnTheGr8
Copy link
Member Author

Cool, will get to it tomorrow...

JohnTheGr8 added a commit to JohnTheGr8/Flow.Launcher that referenced this issue Jul 1, 2020
@JohnTheGr8
remove the hello-world plugins (Flow-Launcher#96)
ca20370
@JohnTheGr8 JohnTheGr8 mentioned this issue Jul 1, 2020
Merged
@jjw24 jjw24 closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnTheGr8 JohnTheGr8

Labels
question/discussion Further information is requested/discussion about a topic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohnTheGr8 @jjw24