Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSX builds to .travis.yml #88

Closed
eugenevinitsky opened this issue Sep 5, 2018 · 5 comments
Closed

Add OSX builds to .travis.yml #88

eugenevinitsky opened this issue Sep 5, 2018 · 5 comments

Comments

@eugenevinitsky
Copy link
Member

We need to test that things pass on OSX as well.

Look at ray's travis.yml for an example of how to do so.

@AboudyKreidieh
Copy link
Member

after looking into this (and trying it), it turns out that this is not a good idea. See: travis-ci/travis-ci#7304

My recommendation is we do not do this.

@eugenevinitsky
Copy link
Member Author

@AboudyKreidieh perhaps we can turn this into a slow test? I will talk to the Ray team; they do this.

@eugenevinitsky
Copy link
Member Author

eugenevinitsky commented Sep 13, 2018

@AboudyKreidieh can you detail the issue you hit when you tried this? I want to see if we can build tests for our setup instructions since this is something we really struggle with

@eugenevinitsky eugenevinitsky added this to High priority (within few days) in Issue Triage Sep 16, 2018
@eugenevinitsky
Copy link
Member Author

Currently blocked by discussion with Travis team

@AboudyKreidieh
Copy link
Member

This doesn't look like it will work out. Fortunately most of us use Macs, so we should be able to keep up with the build like that.

Issue Triage automation moved this from High priority (within few days) to Closed May 19, 2019
Software Upgrades automation moved this from Untriaged to Done May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue Triage
  
Closed
Development

No branches or pull requests

2 participants