-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommended configuration not working with enums #26
Comments
This setting from the recommended configuration that was causing the issue for me: "babelOptions": {
"parserOpts": {
"plugins": [
"flow",
"jsx"
]
}
} Actually, it is only the "flow" plugin that causes the problem. I got it solved by setting an empty Thanks for the plugin btw 🙇 |
I'll be honest I've never used flow enums yet, I'll give it a go today and see what could fix it |
@Brianzchen It seems this should be configuration instead, I couldn't find a flow plugin for babel at least:
|
Ok I just tested this and this is what I've realised, My suggestion here is that we just remove this property completely from the recommended setting, whatever you have defined in your babel config to traverse your code for runtime, testing and now eslint will all be the same. This project won't need to maintain all sorts of settings for different use cases. Also note that this property was originally added before Is that ok with you @maxcnunes? I can make this change quickly and then ship a patch immediately after |
Yeah, makes sense to me, thanks. |
Give v2.0.1 a go |
That worked, thanks! |
I couldn't figure it out yet, but once I add
extends: ['plugin:ft-flow/recommended']
the linter crashes for enum types:Without
ft-flow/recommended
it works though.The text was updated successfully, but these errors were encountered: