-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an "incomplete" libdef namespace for stale, unfinished libdef PRs #178
Comments
How about a |
Okay I just realized you have been discussing this in a PR,... but not sure what the outcome is now? |
Yea, I created this issue just to track the idea independent of the Pull Request. I haven't started working on it or anything yet. |
To avoid limbo (for both - wip namespace and libdefs like lodash) do you think it's reasonable to:
There's no really a need to add any support for now in the cli (really - there's no reason in the first step). After this decision we'll flush couple of PRs that are hanging for months (lodash etc). This will move things a lot already. Then as a second step we can add the |
Hmmm... we will at least need the After a second thought, I think a |
I think #4051 supersedes what this issue set out to accomplish |
Agreed, we can close this. |
As @mirek pointed out over in #42, it's inevitable that we'll have some PRs submitted with an incomplete libdef (such that it doesn't fit the acceptance guidelines -- i.e. tests/too many
any
s/incorrect interfaces/etc) that the author doesn't have time to finish.In these cases, its probably better to just merge these into a namespace that's excluded from the normal
npm
namespace so that someone might come along later and pick up where they've been left off (rather than starting from scratch).Initially we can do this manually, but eventually we should build a bot to help manage this kind of SLA as well as doing the work of tweaking the PR and committing it properly.
The text was updated successfully, but these errors were encountered: