Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "incomplete" libdef namespace for stale, unfinished libdef PRs #178

Closed
jeffmo opened this issue Jul 7, 2016 · 7 comments
Closed
Labels
enhancement An addition to an existing component pr welcome

Comments

@jeffmo
Copy link
Contributor

jeffmo commented Jul 7, 2016

As @mirek pointed out over in #42, it's inevitable that we'll have some PRs submitted with an incomplete libdef (such that it doesn't fit the acceptance guidelines -- i.e. tests/too many anys/incorrect interfaces/etc) that the author doesn't have time to finish.

In these cases, its probably better to just merge these into a namespace that's excluded from the normal npm namespace so that someone might come along later and pick up where they've been left off (rather than starting from scratch).

Initially we can do this manually, but eventually we should build a bot to help manage this kind of SLA as well as doing the work of tweaking the PR and committing it properly.

@jeffmo jeffmo added the enhancement An addition to an existing component label Jul 7, 2016
@ryyppy
Copy link
Contributor

ryyppy commented Jul 7, 2016

How about a $wip namespace and definitions/wip directory, whereby user can define the --wip flag for the install command?

@ryyppy
Copy link
Contributor

ryyppy commented Jul 7, 2016

Okay I just realized you have been discussing this in a PR,... but not sure what the outcome is now?

@jeffmo
Copy link
Contributor Author

jeffmo commented Jul 7, 2016

Yea, $wip namespace would be a fine name too.

I created this issue just to track the idea independent of the Pull Request. I haven't started working on it or anything yet.

@mirek
Copy link

mirek commented Aug 1, 2016

To avoid limbo (for both - wip namespace and libdefs like lodash) do you think it's reasonable to:

  1. just create ./definitions/wip/... directory with structure equivalent to ./definitions/npm/... and
  2. tell people to throw libdefs that need more attention there.

There's no really a need to add any support for now in the cli (really - there's no reason in the first step).

After this decision we'll flush couple of PRs that are hanging for months (lodash etc). This will move things a lot already.

Then as a second step we can add the --wip flag which just merges listing from that directory as if definitions were in npm, that should do the trick.

@ryyppy
Copy link
Contributor

ryyppy commented Aug 3, 2016

Hmmm... we will at least need the --wip flag for the install command.. otherwise it's unnecessarily complicated to look up the queried libdef...

After a second thought, I think a $wip could also make things more complicated (so $npm would just be fine)...
I am in for your proposal to just start migrating longer pending PRs to the definitions/wip directory and merge them... maybe things would get along faster then?

@gantoine gantoine added release Related to the next major release enhancement An addition to an existing component and removed enhancement An addition to an existing component release Related to the next major release labels Nov 13, 2017
@gantoine gantoine added the cli Related to CLI tool label Mar 21, 2018
@gantoine gantoine added pr welcome and removed cli Related to CLI tool labels Nov 29, 2021
@Brianzchen
Copy link
Member

I think #4051 supersedes what this issue set out to accomplish

@gantoine
Copy link
Member

gantoine commented Dec 1, 2021

Agreed, we can close this.

@gantoine gantoine closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An addition to an existing component pr welcome
Projects
None yet
Development

No branches or pull requests

5 participants