Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] I need to add more options when running serve command #44

Closed
hoang-innomize opened this issue Jul 31, 2020 · 5 comments
Closed
Assignees
Labels
Milestone

Comments

@hoang-innomize
Copy link
Contributor

Currently, with the current build target, there is no option available so that I can add more options when running serverless offline. For example, I use serverless-offline-local-authorizers-plugin to run the custom authorizer locally, I need to add a custom option after sls offline command i.e. sls offline local-authorizers --stage dev --region eu-central-1

I think we could add an option i.e. args likes NX run-command builder so that we can add more options without updating our builder schema.

@hoang-innomize hoang-innomize added the enhancement New feature or request label Jul 31, 2020
@hoang-innomize hoang-innomize changed the title I need to add more options when running serve command [FEAT] I need to add more options when running serve command Jul 31, 2020
@wickstargazer
Copy link
Member

sure i will look into it and probably add it in for you in the next publish? 😄

@hoang-innomize
Copy link
Contributor Author

Thank @wickstargazer. I am getting our team to contribute to your plugin, but they will need some time to catch up and learn how to contribute. In the meantime, if you can add and publish a new version, that would be great.

@tstackhouse
Copy link
Collaborator

I'm running into a similar situation with the cloudside plugin, so that my CloudFormation template references resolve properly in my local environment, it needs to invoke sls offline cloudside and I'm not totally sure of how to accomplish that, if I can.

@hoang-innomize
Copy link
Contributor Author

To run a sls command we also use two additional options (--aws-profile and --region), so I think we also need to add two options as well.
For an example: sls deploy --stage sit --aws-profile sit_profile --region us-east-2

@wickstargazer
Copy link
Member

i mixed this with deploy command, have to test to make sure it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants