Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent results when run inside Flowhub #8

Closed
bergie opened this issue Aug 26, 2015 · 4 comments
Closed

Inconsistent results when run inside Flowhub #8

bergie opened this issue Aug 26, 2015 · 4 comments
Labels

Comments

@bergie
Copy link
Member

bergie commented Aug 26, 2015

Here is how Flowhub triggers fbp-spec (with a pre-existing runtime connection): https://github.com/noflo/noflo-ui/blob/master/components/RunTests.coffee

However, the results are inconsistent when shown in the UI:

screen shot 2015-08-26 at 20 05 05

This doesn't conform to what I see in the runtime console where the states appear to be what was expected:

undefined 'Portal c-base space station is L4 RESISTANCE'
undefined 'Portal c-base space station is L8 RESISTANCE'
undefined 'Portal c-base space station is L8 ALIENS'
undefined 'Portal c-base space station (NEUTRAL) is L8 and has disco'
undefined 'Portal c-base space station is L8 RESISTANCE'
undefined 'Portal c-base space station has special disco mods'
undefined 'Portal c-base space station has special disco mods’

When the same tests are run inside Node.js Mocha runner, they all pass: https://travis-ci.org/c-base/ingress-table/builds/77374093#L446

@bergie
Copy link
Member Author

bergie commented Aug 26, 2015

Similar thing appears to happen when running multiple suites, with the latter suite receiving the output of the first one:

screen shot 2015-08-26 at 20 52 56

These also pass with Node.js Mocha: https://travis-ci.org/noflo/noflo-hackrf/builds/77363801#L221

@jonnor jonnor added the bug label Aug 27, 2015
@jonnor
Copy link
Contributor

jonnor commented Aug 27, 2015

Probably something in runner.coffee, in which case it should also manifest when running tests with fbp-spec executable.

@jonnor
Copy link
Contributor

jonnor commented Aug 27, 2015

Could also be that if the runtime sends messages from an old network, we don't properly ignore them.
Possibly related to that we (currently) never send a network:stop message.

@jonnor
Copy link
Contributor

jonnor commented Aug 27, 2015

Think I solved the Ingress Table issue in c-base/ingress-table@c524173

@bergie bergie closed this as completed Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants