Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support atf in install space #176

Merged
merged 2 commits into from Feb 26, 2021
Merged

support atf in install space #176

merged 2 commits into from Feb 26, 2021

Conversation

floweisshardt
Copy link
Owner

fixes #175

fmessmer
fmessmer requested changes Feb 26, 2021
View reviewed changes
Copy link
Collaborator

@fmessmer fmessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you add comments, have a look at my suggestions

I'll prepare a PR for mojin_atf to test this feature branch....I'd suggest to hold merging until we confirm it wors for mojin_atf

atf_core/cmake/atf_core-extras.cmake.em Outdated Show resolved Hide resolved
atf_core/cmake/atf_core-extras.cmake.em Outdated Show resolved Hide resolved
atf_core/cmake/atf_core-extras.cmake.em Outdated Show resolved Hide resolved
atf_core/cmake/atf_core-extras.cmake.em Outdated Show resolved Hide resolved
@fmessmer
Copy link
Collaborator

fmessmer commented Feb 26, 2021 •
edited

ah, we can only test this properly when this atf feature branch is used in our docker images
I'll prepare something

@benmaidel
Copy link

Strange that there is nowhere any documentation about the @ syntax. Is this perhaps something special from the catkin_package(CFG_EXTRAS... function?

@floweisshardt @fmessmer
apply code comments from @fmessmer
be8e14d 
Co-authored-by: Felix Messmer <felixmessmer@gmail.com>
@floweisshardt floweisshardt merged commit 577c1ee into master Feb 26, 2021
@floweisshardt floweisshardt deleted the feature/install_space branch April 14, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmessmer fmessmer fmessmer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

atf cannot be used from install space
3 participants
@floweisshardt @fmessmer @benmaidel