Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to contribute? #103

Closed
roseduan opened this issue Apr 5, 2022 · 0 comments
Closed

How to contribute? #103

roseduan opened this issue Apr 5, 2022 · 0 comments

Comments

@roseduan
Copy link
Collaborator

roseduan commented Apr 5, 2022

简体中文

Familiar with Pull Request

  • add Test Case
  • add example code

There are no Test methods for some API in rosedb, you can add test cases according to the existed.

And you can also add some example code to show users how to use rosedb(under examples dir).
https://github.com/flower-corp/rosedb/tree/main/examples

This kind PRs only aims to let you deep into rosedb and understand more about how it works.

Easy problems

  • add more Redis commands
  • good first issue
  • add Redis command

The commands in rosedb are most similar to Redis, our goal is to support the most frequently used commands in Redis, and make sure the command does not exist in rosedb before you add it.

Redis commands docs: https://redis.io/commands

If an issue is marked with good first issue, it is suitable for newcomers, you can pick one which you are interested in or good at.

Now rosedb has supported Redis protocol, but some commands are missed, so you can add the command:

  • find variable supportedCommands in cmd/cli.go, which lists all supported commands and its handler function
  • find a method in rosedb not listed here
  • add the command and its handler function

Fix bugs or add/enhance features

If an issue is marked with bug or enhancement, which means bug fix or add/enhance features, you might have to understand completely rosedb to solve it.

Note

every issue is marked with its difficulty(easy, medium, hard), you can pick them according to your understanding of rosedb, and if you have any problems, contact me as soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant