Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][scaleph-plugin]Add clickhouse datasource and clickhouse-sink plugin #184

Merged
merged 3 commits into from
Aug 15, 2022
Merged

[Feature][scaleph-plugin]Add clickhouse datasource and clickhouse-sink plugin #184

merged 3 commits into from
Aug 15, 2022

Conversation

lizu18xz
Copy link
Contributor

@lizu18xz lizu18xz commented Aug 14, 2022 •
edited by kalencaya

Purpose of this pull request

contribute #185

Brief change log

  • add clickhouse sink connector

Check list

  • Code changed are covered with tests, or it does not need tests for reason:
  • If necessary, please update the documentation to describe the new feature.

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
3.2% 3.2% Duplication

@kalencaya kalencaya added the feature New feature or request label Aug 14, 2022
@kalencaya
Copy link
Collaborator

kalencaya commented Aug 14, 2022 •
edited

Congratulation for your contributions and welcome to join scaleph!

Now scaleph is cultivating community ecosystem and trys to open team cooperation through zenhub, which is an excellent chrome plugin for github. Except that, scaleph will sponsor weekly online meeting on Tuesday 20:30.

Of course, you need not to trouble that must join some channel or pipeline, scaleph is open, equality and respect.

@lizu18xz
Copy link
Contributor Author

Congratulation for your contributions and welcome to join scaleph!

Now scaleph is cultivating community ecosystem and trys to open team cooperation through zenhub, which is an excellent chrome plugin for github. Except that, scaleph will sponsor weekly online meeting on Tuesday 20:30.

Of course, you need not to trouble that must join some channel or pipeline, scaleph is open, equality and respect.

OK, I'm in the wechat group

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

gleiyu
gleiyu reviewed Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@gleiyu gleiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gleiyu gleiyu changed the title Add clickhouse datasource and clickhouse-sink plugin [Feature][scaleph-plugin]Add clickhouse datasource and clickhouse-sink plugin Aug 15, 2022
@gleiyu gleiyu merged commit 8d16d08 into flowerfine:dev Aug 15, 2022
@gleiyu gleiyu linked an issue Aug 15, 2022 that may be closed by this pull request
[Feature][scaleph-engine-seatunnel] add clickhouse sink connector based on seatunnel #185
Closed
3 tasks
@lizu18xz lizu18xz deleted the feature/clickhouse-sink branch October 1, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gleiyu gleiyu gleiyu approved these changes

Assignees

@lizu18xz lizu18xz

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][scaleph-engine-seatunnel] add clickhouse sink connector based on seatunnel
3 participants
@lizu18xz @kalencaya @gleiyu