Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][scaleph-ui-react] function hasPrivilege json parse error #220

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

hx23840
Copy link
Contributor

@hx23840 hx23840 commented Aug 31, 2022

if user first login,function hasPrivilege of auth.ts json parse error #219

Purpose of this pull request

Brief change log

  • fix auth.ts function hasPrivilege json parse error

Check list

  • Code changed are covered with tests, or it does not need tests for reason:
  • If necessary, please update the documentation to describe the new feature.

if user first login,function hasPrivilege of auth.ts json parse error
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@hx23840 hx23840 closed this Aug 31, 2022
@hx23840 hx23840 reopened this Aug 31, 2022
@hx23840 hx23840 changed the title [Bug][scaleph-ui-react] function hasPrivilege json parse error (#219) [Bug][scaleph-ui-react] function hasPrivilege json parse error #219 Aug 31, 2022
@hx23840 hx23840 changed the title [Bug][scaleph-ui-react] function hasPrivilege json parse error #219 [Bug][scaleph-ui-react] function hasPrivilege json parse error Aug 31, 2022
kalencaya
kalencaya previously approved these changes Aug 31, 2022
@kalencaya
Copy link
Collaborator

LGTM

@kalencaya kalencaya added the bug Something isn't working label Aug 31, 2022
@kalencaya
Copy link
Collaborator

Congratulation for your contributions and welcome to join scaleph!

Now scaleph is cultivating community ecosystem and trys to open team cooperation through zenhub, which is an excellent chrome plugin for github. Except that, scaleph will sponsor weekly online meeting on Tuesday 20:30.

Of course, you need not to trouble that must join some channel or pipeline, scaleph is open, equality and respect.

@gleiyu gleiyu self-requested a review August 31, 2022 13:05
@gleiyu
Copy link
Collaborator

gleiyu commented Aug 31, 2022

This is a data type conversion problem, empty string can't convert to json, but null value can works well.
localStorage.getItem(USER_AUTH.pCodes) + '' result is null value

if user first login,function hasPrivilege of auth.ts json parse error
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@hx23840
Copy link
Contributor Author

hx23840 commented Aug 31, 2022

This is a data type conversion problem, empty string can't convert to json, but null value can works well. localStorage.getItem(USER_AUTH.pCodes) + '' result is null value

Modified as required

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kalencaya kalencaya merged commit 26d6526 into flowerfine:dev Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants